Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

ref(core): Add mechanism.type to trpcMiddleware errors #17287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 3 commits into develop from lms/ref-core-mechanism-trpc
Sep 8, 2025

Conversation

Copy link
Member

@Lms24 Lms24 commented Aug 1, 2025 •
edited
Loading

ref #17252
closes #17212

seer-by-sentry[bot] reacted with hooray emoji
@Lms24 Lms24 self-assigned this Aug 1, 2025
@Lms24 Lms24 mentioned this pull request Aug 1, 2025
4 tasks
@Lms24 Lms24 force-pushed the lms/ref-core-mechanism-trpc branch from e2e5a44 to 0829c34 Compare August 7, 2025 16:09
@Lms24 Lms24 force-pushed the lms/ref-core-mechanism-trpc branch from 0829c34 to c5bcecc Compare September 5, 2025 13:32
Copy link
Contributor

github-actions bot commented Sep 5, 2025 •
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 9,121 - 9,286 -2%
GET With Sentry 1,345 15% 1,306 +3%
GET With Sentry (error only) 5,921 65% 6,017 -2%
POST Baseline 1,202 - 1,205 -0%
POST With Sentry 501 42% 492 +2%
POST With Sentry (error only) 1,049 87% 1,056 -1%
MYSQL Baseline 3,366 - 3,365 +0%
MYSQL With Sentry 403 12% 465 -13%
MYSQL With Sentry (error only) 2,691 80% 2,740 -2%

View base workflow run

@Lms24 Lms24 force-pushed the lms/ref-core-mechanism-trpc branch from c5bcecc to 4f9685a Compare September 5, 2025 14:56
Copy link
Contributor

github-actions bot commented Sep 5, 2025

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 24.17 kB - -
@sentry/browser - with treeshaking flags 22.75 kB - -
@sentry/browser (incl. Tracing) 40.14 kB - -
@sentry/browser (incl. Tracing, Replay) 78.5 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.26 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 83.18 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 95.38 kB - -
@sentry/browser (incl. Feedback) 40.91 kB - -
@sentry/browser (incl. sendFeedback) 28.82 kB - -
@sentry/browser (incl. FeedbackAsync) 33.77 kB - -
@sentry/react 25.89 kB - -
@sentry/react (incl. Tracing) 42.11 kB - -
@sentry/vue 28.66 kB - -
@sentry/vue (incl. Tracing) 41.95 kB - -
@sentry/svelte 24.2 kB - -
CDN Bundle 25.76 kB - -
CDN Bundle (incl. Tracing) 40.01 kB - -
CDN Bundle (incl. Tracing, Replay) 76.29 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 81.75 kB - -
CDN Bundle - uncompressed 75.2 kB - -
CDN Bundle (incl. Tracing) - uncompressed 118.31 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 233.4 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 246.16 kB - -
@sentry/nextjs (client) 44.14 kB - -
@sentry/sveltekit (client) 40.58 kB - -
@sentry/node-core 49.66 kB - -
@sentry/node 150.6 kB -0.02% -23 B 🔽
@sentry/node - without tracing 92.23 kB - -
@sentry/aws-serverless 105.53 kB - -

View base workflow run

@Lms24 Lms24 marked this pull request as ready for review September 5, 2025 15:14
@Lms24 Lms24 requested review from a team, mydea and andreiborza and removed request for a team September 5, 2025 15:14
Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@Lms24 Lms24 merged commit 4745177 into develop Sep 8, 2025
188 checks passed
@Lms24 Lms24 deleted the lms/ref-core-mechanism-trpc branch September 8, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreiborza andreiborza andreiborza approved these changes

@mydea mydea Awaiting requested review from mydea mydea was automatically assigned from getsentry/team-web-sdk-frontend

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure SDK-captured error events have a proper mechanism

AltStyle によって変換されたページ (->オリジナル) /